Fix Bash completion script to no longer alter your shell's settings.

This commit is contained in:
Dan Helfman 2022-06-09 16:29:54 -07:00
parent 0e90a80680
commit 65b2fe86c6
2 changed files with 2 additions and 1 deletions

2
NEWS
View file

@ -5,6 +5,8 @@
https://torsion.org/borgmatic/docs/how-to/inspect-your-backups/#searching-for-a-file https://torsion.org/borgmatic/docs/how-to/inspect-your-backups/#searching-for-a-file
* #543: Add a monitoring hook for sending push notifications via ntfy. See the documentation for * #543: Add a monitoring hook for sending push notifications via ntfy. See the documentation for
more information: https://torsion.org/borgmatic/docs/how-to/monitor-your-backups/#ntfy-hook more information: https://torsion.org/borgmatic/docs/how-to/monitor-your-backups/#ntfy-hook
* Fix Bash completion script to no longer alter your shell's settings (complain about unset
variables or error on pipe failures).
* Deprecate "borgmatic list --successful" flag, as listing only non-checkpoint (successful) * Deprecate "borgmatic list --successful" flag, as listing only non-checkpoint (successful)
archives is now the default in newer versions of Borg. archives is now the default in newer versions of Borg.

View file

@ -30,7 +30,6 @@ def bash_completion():
# Avert your eyes. # Avert your eyes.
return '\n'.join( return '\n'.join(
( (
'set -uo pipefail',
'check_version() {', 'check_version() {',
' local this_script="$(cat "$BASH_SOURCE" 2> /dev/null)"', ' local this_script="$(cat "$BASH_SOURCE" 2> /dev/null)"',
' local installed_script="$(borgmatic --bash-completion 2> /dev/null)"', ' local installed_script="$(borgmatic --bash-completion 2> /dev/null)"',